Changes between Initial Version and Version 1 of Ticket #36179, comment 6
- Timestamp:
- Mar 3, 2014, 11:51:07 PM (11 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #36179, comment 6
initial v1 1 Looks good at first sight – unfortunately I can't test right now because my working copy is busy tracking other changes and I don't want to risk mix them (why don't we use git again? :/).1 Looks good at first sight – unfortunately I can't test right now because my working copy is busy tracking other changes and I don't want to risk mixing them (why don't we use git again? :/). 2 2 3 3 One thing I noticed is that your changes put `set group [lindex $portlist 0]` before the length check of `$portlist`. Since `lindex` doesn't fail on invalid indices that's not a problem per-se, I just think it would be a little cleaner to move it after the check.