icu upgrade 49.1.2_0 < 49.1.2_1 fails on 10.5.8 PPC

[ned-deily (Ned Deily)]

:info:build /usr/bin/gcc-4.0 -DU_ATTRIBUTE_DEPRECATED= -DU_COMMON_IMPLEMENTATION     -I.   "-DDEFAULT_ICU_PLUGINS=\"/macports/lib/icu\" " -pipe -O2 -arch ppc -O2 -ansi -pedantic -Wshadow -Wpointer-arith -
Wmissing-prototypes -Wwrite-strings -Wno-long-long   -fno-common -c   -o umutex.ao umutex.c
:info:build In file included from umutex.h:30,
:info:build                  from ucln.h:21,
:info:build                  from ucln_cmn.h:21,
:info:build                  from umutex.c:23:
:info:build /usr/include/libkern/OSAtomic.h:71: error: syntax error before ‘static’
:info:build /usr/include/libkern/OSAtomic.h:74: error: syntax error before ‘static’
:info:build /usr/include/libkern/OSAtomic.h:78: error: syntax error before ‘static’
:info:build /usr/include/libkern/OSAtomic.h:81: error: syntax error before ‘static’
:info:build gnumake[1]: *** [umutex.ao] Error 1

[jeremyhu (Jeremy Huddleston Sequoia)]

I guess gcc-4.0 doesn't like the attribute((always_inline))

Can you please remove that from the clang-assert.patch that I added, clean, and try again?

[jeremyhu (Jeremy Huddleston Sequoia)]

Oh, and why are you using gcc-4.0 on Leopard? You should have gcc-4.2 there...

[ned-deily (Ned Deily)]

gcc-4.0 is the default for /usr/bin/cc and /usr/bin/gcc on Leopard, AFAIK.

[jeremyhu (Jeremy Huddleston Sequoia)]

Replying to nad@…:

gcc-4.0 is the default for /usr/bin/cc and /usr/bin/gcc on Leopard, AFAIK.

I don't think so, but that's not really relevant here. /usr/bin/gcc-4.0 is being executed. base should choose gcc-4.2 for XCode 3.0.x ... What version of XCode are you using on Leopard?

[ned-deily (Ned Deily)]

Sorry, must be late: I don't see a clang-assert.patch in port icu.

# xcodebuild -version
Xcode 3.1.4
Component versions: DevToolsCore-1204.0; DevToolsSupport-1186.0
BuildVersion: 9M2809

According to the Xcode 3.1.4 Release Notes, "GCC 4.2 is a new optional compiler". It is there but gcc-4.0 is the default. That's the case on all of my Xcode 3.1.4 installations, PPC and Intel. Always has been.

[jeremyhu (Jeremy Huddleston Sequoia)]

Sorry, wrong patch name... that change was for a different port.

r101785 should fix you up, but I'm still concerned about it picking gcc-4.0 for you... it should be choosing gcc-4.2.

Your XCode release notes are irrelevant. It's base that determines what is run. What version of base do you have?

port version

[ned-deily (Ned Deily)]

Thanks, r101785 appears to fix the build failure.

# port selfupdate
--->  Updating MacPorts base sources using rsync
MacPorts base version 2.1.2 installed,
MacPorts base version 2.1.2 downloaded.
--->  Updating the ports tree
--->  MacPorts base is already the latest version

The ports tree has been updated. To upgrade your installed ports, you should run
  port upgrade outdated
# port -k upgrade icu
--->  Fetching distfiles for icu
--->  Verifying checksum(s) for icu
--->  Extracting icu
--->  Applying patches to icu
--->  Configuring icu
--->  Building icu
--->  Staging icu into destroot
--->  Installing icu @49.1.2_1
--->  Deactivating icu @49.1.2_0
--->  Cleaning icu
--->  Activating icu @49.1.2_1
--->  Updating database of binaries: 100.0%
--->  Scanning binaries for linking errors: 100.0%
--->  No broken files found.

icu/config.log attached: still using /usr/bin/gcc-4.0.

[ryandesign (Ryan Carsten Schmidt)]

Replying to jeremyhu@…:

Oh, and why are you using gcc-4.0 on Leopard? You should have gcc-4.2 there...

Yes, Leopard has gcc-4.2, but gcc-4.0 has always been the default compiler in MacPorts on Leopard. You and I talked once about maybe changing that, but as of MacPorts 2.1.2 it has not changed.

[cooljeanius (Eric Gallager)]

Cc Me!