Changes between Initial Version and Version 1 of Ticket #38379, comment 7
- Timestamp:
- Mar 13, 2013, 9:58:35 PM (12 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #38379, comment 7
initial v1 1 1 ok, after building, I have the following comments: 2 2 3 - Since you're patching Makefile.am and configure.ac anyways, you might as well silence the glibtoolize warnings , i.e.:3 - Since you're patching Makefile.am and configure.ac anyways, you might as well silence the glibtoolize warnings while you're at it, i.e.: 4 4 {{{ 5 5 glibtoolize: Consider adding `AC_CONFIG_MACRO_DIR([m4])' to configure.ac … … 10 10 }}} 11 11 - The +mysql4 and +mysql5 variants should probably conflict with one another 12 - mysql4 is old and obsolete anyway (I couldn't get it to build on Lion), so you could also just leave out the +mysql4 variant 12 - mysql4 is old and obsolete anyway (I couldn't get it to build on Lion), so you could also just leave out the +mysql4 variant instead 13 13 - my [https://github.com/cooljeanius/macportsscripts/blob/v0.1.4/port-depcheck.sh port-depcheck.sh] script says that `sysbench` doesn't actually link against openssl or zlib; do those really need to be added as dependencies? Although then again I like to add lots of irrelevant dependencies when writing my own ports, so who am I to talk... 14 14