MacVim @7.3.snapshot66_3: should use vim's vimfiles directory

[larryv (Lawrence Velázquez)]

A number of ports install Vim support files into ${prefix}/share/vim/vimfiles. MacVim currently doesn’t pick these up.

The attached patch corrects this by adding the vim port’s vimfiles directory to MacVim’s default runtimepath.

Another option would be to create a symlink at ${applications_dir}/MacVim.app/Contents/Resources/vim/vimfiles pointing to ${prefix}/share/vim/vimfiles, but that feels a little sneaky to me. It would admittedly be a little simpler.

[larryv (Lawrence Velázquez)]

patch to change MacVim's default runtimepath

[raimue (Rainer Müller)]

Hm, I think the framework solution would be okay as well. Due to the linking with libraries from ports and hardcoded paths to binaries the resulting MacVim.app is not portable anyway.

[larryv (Lawrence Velázquez)]

I don’t feel particularly strongly one way or the other.

On the one hand, tweaking runtimepath is mildly more transparent about where the added runtime files are coming from, and it ensures that the MacPorts vimfiles directories are always searched, even if the user changes $VIM. (This could just as easily be considered a drawback.)

On the other, it is additional code that would have to be maintained.

[g5pw (Aljaž Srebrnič)]

Well, the link solution surely is easier, I'd say let the maintainer decide. :)

[cooljeanius (Eric Gallager)]

Cc Me!

[raimue (Rainer Müller)]

Another point that came to mind, what would happen if the vimfiles directory does not exist yet? Should we just put a dummy file there to silence any warnings? However, I still have not tested this yet.