Changes between Version 1 and Version 2 of Ticket #51610, comment 1


Ignore:
Timestamp:
Jun 28, 2016, 7:27:50 PM (8 years ago)
Author:
mf2k (Frank Schima)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #51610, comment 1

    v1 v2  
    11Comments:
    22 - In general, we do not set {{{distfiles}}} directly, it is best practice to set ${distname} and ${extract.suffix} separately. In fact, I believe the {{{distfiles}}} line in the Portfile is the default value and should simply be removed.
    3  - Considering adding {{{openmaintainer}}} since you are not a committer.
     3 - Consider adding {{{openmaintainer}}} since you are not a committer.
    44 - Is there a non-FTP master_sites location?
    55 - Have you tested this when building {{{+universal}}}? You are overriding the {{{configure.args}}} which are set by the [browser:trunk/dports/_resources/port1.0/group/muniversal-1.0.tcl muniversal PortGroup].