Changes between Initial Version and Version 1 of Ticket #52210, comment 9


Ignore:
Timestamp:
Nov 2, 2016, 11:41:18 AM (8 years ago)
Author:
mojca (Mojca Miklavec)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #52210, comment 9

    initial v1  
    5151make: *** [build/SDL_cocoaevents.lo] Error 1
    5252}}}
     53
     54After applying the following patch:
     55{{{
     56#!diff
     57--- src/video/cocoa/SDL_cocoaevents.m.orig
     58+++ src/video/cocoa/SDL_cocoaevents.m
     59@@ -328,6 +328,7 @@ CreateApplicationMenus(void)
     60     [windowMenu release];
     61 
     62 
     63+    #if defined NSAppKitVersionNumber10_6
     64     /* Add the fullscreen view toggle menu option, if supported */
     65     if (floor(NSAppKitVersionNumber) > NSAppKitVersionNumber10_6) {
     66         /* Create the view menu */
     67@@ -345,6 +346,7 @@ CreateApplicationMenus(void)
     68 
     69         [viewMenu release];
     70     }
     71+    #endif
     72 }
     73 
     74 void
     75}}}
     76it eventually fails with:
     77{{{
     78  CC     build/SDL_cocoaevents.lo
     79/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libsdl2/libsdl2/work/SDL2-2.0.5/src/video/cocoa/SDL_cocoaevents.m:249:13: warning: unused variable 'viewMenu' [-Wunused-variable]
     80    NSMenu *viewMenu;
     81            ^
     82/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libsdl2/libsdl2/work/SDL2-2.0.5/src/video/cocoa/SDL_cocoaevents.m:447:9: warning: implicit declaration of function 'IOPMAssertionCreateWithDescription' is invalid in C99 [-Wimplicit-function-declaration]
     83        IOPMAssertionCreateWithDescription(kIOPMAssertPreventUserIdleDisplaySleep,
     84        ^
     85/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libsdl2/libsdl2/work/SDL2-2.0.5/src/video/cocoa/SDL_cocoaevents.m:447:44: error: use of undeclared identifier 'kIOPMAssertionTypePreventUserIdleDisplaySleep'
     86        IOPMAssertionCreateWithDescription(kIOPMAssertPreventUserIdleDisplaySleep,
     87                                           ^
     88/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libsdl2/libsdl2/work/SDL2-2.0.5/src/video/cocoa/SDL_cocoaevents.m:33:48: note: expanded from macro 'kIOPMAssertPreventUserIdleDisplaySleep'
     89#define kIOPMAssertPreventUserIdleDisplaySleep kIOPMAssertionTypePreventUserIdleDisplaySleep
     90                                               ^
     912 warnings and 1 error generated.
     92make: *** [build/SDL_cocoaevents.lo] Error 1
     93}}}