Opened 8 years ago
Last modified 7 years ago
#52954 closed defect
xlsx2csv @1.2 darwin: bad bash test for gnused searching exact file gsed without path and never to be found — at Version 1
Reported by: | energo80 | Owned by: | kirk@… |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.3.5 |
Keywords: | haspatch | Cc: | ryandesign (Ryan Carsten Schmidt) |
Port: | xlsx2csv |
Description (last modified by ryandesign (Ryan Carsten Schmidt))
This is current code in line
gnused=$(which sed) [[ "${platform}" == "Darwin" ]] && gnused=gsed [[ -f "$gnused" ]] || { ERROR....}
should be changed to
which $gnused || error
Change History (2)
comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
Cc: | ryandesign added |
---|---|
Description: | modified (diff) |
Keywords: | haspatch added |
Owner: | changed from macports-tickets@… to kirk@… |
Status: | new → assigned |
Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
Attachment: | xlsx2csv.diff added |
---|
Note: See
TracTickets for help on using
tickets.
You should not rely on
which
returning a nonzero exit code when a program is not found; on Tiger, it doesn't do that.I propose a different fix; attached.