Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#53424 closed submission (fixed)

hstr @1.21 : Bash and Zsh shell history suggest box

Reported by: 1-61803 Owned by: mf2k (Frank Schima)
Priority: Normal Milestone:
Component: ports Version: 2.3.5
Keywords: Cc:
Port: hstr

Description


Attachments (2)

Portfile (1.3 KB) - added by 1-61803 8 years ago.
Portfile2 (1.3 KB) - added by 1-61803 8 years ago.

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by 1-61803

Attachment: Portfile added

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Change depends_build to depends_build-append and depends_lib to depends_lib-append to not overwrite dependencies pulled in from the GitHub portgroup and by using use_autoreconf yes.

Changed 8 years ago by 1-61803

Attachment: Portfile2 added

comment:2 Changed 8 years ago by 1-61803

I must have missed that part in the guide. Thanks for pointing it out.

Last edited 8 years ago by 1-61803 (previous) (diff)

comment:3 Changed 8 years ago by mf2k (Frank Schima)

Owner: set to mf2k
Resolution: fixed
Status: newclosed

In bc3e8e22/macports-ports:

hstr: New port.

Closes: #53424

comment:4 Changed 8 years ago by mf2k (Frank Schima)

Note:

  • I added the dependency on ncurses because it was using it.
  • I fixed the spacing to conform to the mode line.

comment:5 Changed 8 years ago by 1-61803

readline already depends on ncurses — why is it necessary to add ncurses also in hstr's portfile?

Last edited 8 years ago by 1-61803 (previous) (diff)

comment:6 Changed 8 years ago by mf2k (Frank Schima)

The rule of thumb is if the port directly depends on it, then the dependency should be added. If ncurses gets an API change, we can easily know which ports will be affected before it gets committed and breaks it!

comment:7 Changed 8 years ago by mf2k (Frank Schima)

For reference:

$ otool -L /opt/local/bin/hstr
/opt/local/bin/hstr:
	/opt/local/lib/libncurses.6.dylib (compatibility version 6.0.0, current version 6.0.0)
	/opt/local/lib/libreadline.6.dylib (compatibility version 6.0.0, current version 6.3.0)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1238.0.0)
Note: See TracTickets for help on using tickets.