#53457 closed defect (wontfix)
_resources/port1.0/livecheck/googlecode.tcl: livecheck broken
Reported by: | l2dy (Zero King) | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | mojca (Mojca Miklavec) | |
Port: |
Description
Google Code is using angular now and livecheck could only find a <div ng-view></div>
.
Example URL: http://code.google.com/p/arowpp/downloads/list --302--> https://code.google.com/archive/p/arowpp/downloads
Change History (10)
comment:1 Changed 8 years ago by mojca (Mojca Miklavec)
Cc: | mojca added |
---|
comment:2 Changed 8 years ago by mojca (Mojca Miklavec)
comment:3 Changed 8 years ago by l2dy (Zero King)
The problem is I'm going to run port livecheck all
from time to time and checking these ports would be a waste of time.
comment:4 Changed 8 years ago by mojca (Mojca Miklavec)
Another option (I'm not sure how to implement that though) would be to throw some more informative warning. Instead of getting the useless
Error: cannot check if FOO was updated (regex didn't match)
it would help if port livecheck -v
would return something like
Warning: FOO is hosted on google code which is no longer being updated
(but of course with a better message).
Again, as a quick fix we could also disable livecheck if needed, but let's make a ticket with all google code projects first.
comment:5 Changed 8 years ago by l2dy (Zero King)
comment:6 Changed 8 years ago by l2dy (Zero King)
ag -G Portfile -l 'master_sites[ \t]+googlecode' | awk -F/ '{print $2}' | tr '\n' ' ' | sed 's/ /, /g'
namebench, qlipper, xar, lastfmlib, libofa, rgm3800py, s710, asmotor, atf, closure-linter, cmockery, darts-clone, distcc, fortrancl, google-ctemplate, ocaml-bitstring, ocaml-extlib, qdjango, qxmpp, re2, rlog, sbt-0.7, yaml-cpp, sigil, log4erl, bindfs, s3fs, libkml, flam3, gpick, libguichan, sam2p, squish, tif22pnm, dircproxy, appengine-java-sdk, dex2jar, dualist, fantom, google-collections, hamcrest-core, hamcrest-library, lucene-gosen2, lucene-gosen4, microemu, objenesis, scala-migrations, spymemcached, arowpp, bayon, crfpp, crfpp-devel, oll, plda, mp4v2, tovid, csshX, dsocks, exabgp, flowd, gsutil, naim, pdsh, php-peb, ttf2eot, py-amqplib, py-apsw, py-argparse, py-bitstring, py-chm2pdf, py-djvubind, py-gchartwrapper, py-gdata, py-gflags, py-graphy, py-gslib, py-gtfs, py-gviz_api, py-harstorage, py-hcluster, py-iniparse, py-ipaddr, py-lepton, py-libdnet, py-libnamebench, py-lockfile, py-mingus, py-mox, py-nmrglue, py-pdfrw, py-pebl, py-progressbar, py-psychopy, py-pybonjour, py-pybox2d, py-pydot, py-pygraph-core, py-pygraph-dot, py-pymunk, py-pyodbc, py-pypcap, py-pysam, py-rfoo, py-sqlite, py-tesser, py-twitter, py-winpdb, py-workerpool, py-xar, py27-webkitgtk, log2timeline, openfpc, reaver, skipfish, crswallow, exec-wrapper, macports-notifier, memcachedb, memcacheq, nrg4iso, pssh, synergy-devel, zsh-templates-osx, dot2texi, agree, backward, cabocha, cpi00, daisydiff, epubcheck, giza-pp, iksemel, liblouis, liblouisxml, marisa-trie, pdf2json, rst2pdf, stardict, txt2tags, ux-trie, arora, blazeblogger, googlecl, mod_authn_otp, mongoose, sitemap_gen, xdotool,
comment:7 Changed 8 years ago by l2dy (Zero King)
I've created #53467, can we disable livecheck for these ports now?
comment:8 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
You are certain that all of the ports currently hosted at googlecode are at their latest googlecode version? I'm not. If not, then we should fix googlecode livecheck so that it works properly.
comment:9 Changed 8 years ago by l2dy (Zero King)
I just don't think it would worth the effort. After all these ports are upgraded to latest version on Google Code or moved, googlecode livecheck should be disabled anyway.
If you're interested in fixing it, here's a new URL: https://www.googleapis.com/storage/v1/b/google-code-archive/o/v2%2Fcode.google.com%2Farowpp%2Fdownloads-page-1.json?alt=media&stripTrailingSlashes=false
Edit: Unless moved to ...
is also detected programmatically, we have to go through every port manually anyway. That's why I said it wouldn't worth the effort. Still some ports might have moved without a notice or redirect on Google Code.
comment:10 Changed 7 years ago by l2dy (Zero King)
Resolution: | → wontfix |
---|---|
Status: | new → closed |
port's livecheck for Google Code projects could only checks updates on Google Code and can be broken if livecheck.regex was overridden.
Were we to go through the ports with a script, the script needs to detect moved projects and updates within Google Code for projects that didn't move. We should also search on GitHub and Google for possible active forks or new locations not mentioned on Google Code.
I would prefer to keep the livecheck broken for now and rather have a ticket with all ports that still use google code and start an effort to move those ports away from google code.
The particular example of arowapp: the "homepage" says:
so we should use a GitHub PortGroup and fix the port anyway.
We should not be using google code for anything but obsolete software that is no longer maintained. Disabling the livecheck as a quick fix will just hide the problem. Sure, we may disable it eventually, but we certainly need a ticket tracking progress of moving ports away from google code.