Changes between Initial Version and Version 1 of Ticket #53974, comment 19
- Timestamp:
- Jun 5, 2017, 7:24:33 AM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #53974, comment 19
initial v1 2 2 > The patch above points to the right direction, but doesn't seem to be entirely correct. Here's a revised patch written by Akira Kakuto. Can you please test that one? 3 3 4 Akira's patch is correct. Separately allocating/freeing colordat isn't actually necessary, but colordat should probably be a single pointer, not a pair.4 Akira's patch is correct. I was thinking that separately allocating colordat isn't necessary, but actually it is. The declaration colordat[2] was evidently a hack to get avoid that allocation, but clang won't let you get away with it. So changing colordat to a single pointer and separately allocating/freeing it is correct. Thanks to Akira Kakuto for clear thinking :)