1 | | Replying to [comment:8 ryandesign]: |
2 | | |
3 | | > So checking whether it is defined is not enough; |
4 | | |
5 | | That is the error upstream made that broke the 32bit build for you, which I spotted in 10 seconds once I looked and fixed for us. And upstream was making again, when I went there, BTW... |
6 | | |
7 | | |
8 | | |
9 | | > |
10 | | > > And BTW what works on clang does not necessarily work on gcc-4.2, blah, blah, blah. |
11 | | > |
12 | | > Why would you say that? |
13 | | |
14 | | It's the serial tests on one line, not the {{{__LP64__}}}, that I have noted can be handled differently. All I'm saying there is if you just test with {{{clang}}} but not with {{{gcc-4.2}}}, then you'll miss things that will have to be fixed later. |
15 | | |
16 | | |
| 1 | I shall endeavour to make sure the test is as robust as possible upstream. Thanks! |