Opened 4 years ago

Closed 4 years ago

#60986 closed enhancement (fixed)

mame @0.206 Variant proposal to install mame tools and man pages

Reported by: rhuelga (Roberto Huelga) Owned by: mascguy (Christopher Nielsen)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: mame

Description (last modified by rhuelga (Roberto Huelga))

I have modified the portfile to create a variant +tools that compile and install some of the mame tools and their man pages:

  • castool
  • chdman
  • floptool
  • imgtool
  • jedutil
  • ldresample
  • ldverify
  • romcmp

It's interesting to note that other commands get compiled, maybe some of them worth to be installed too.

  • aueffectutil
  • nltool
  • nlwav
  • pngcmp
  • regrep
  • split
  • src2html
  • srcclean
  • unidasm
--- Portfile.orig       2019-12-02 19:32:36.000000000 +0100
+++ Portfile    2020-08-11 11:19:44.000000000 +0200
@@ -82,8 +82,33 @@
     set executable  mame
 }

+variant tools description {compile and install the mame tools like chdman and others} {
+    build.args-append  TOOLS=1
+}
+
 destroot {
     xinstall ${worksrcpath}/${executable} ${destroot}${prefix}/bin
+    xinstall ${worksrcpath}/docs/man/mame.6 ${destroot}${prefix}/share/man/man6
+
+    if {[variant_isset tools]} {
+        xinstall ${worksrcpath}/castool \
+            ${worksrcpath}/chdman \
+            ${worksrcpath}/floptool \
+            ${worksrcpath}/imgtool \
+            ${worksrcpath}/jedutil \
+            ${worksrcpath}/ldresample \
+            ${worksrcpath}/ldverify \
+            ${worksrcpath}/romcmp ${destroot}${prefix}/bin
+
+        xinstall ${worksrcpath}/docs/man/castool.1 \
+            ${worksrcpath}/docs/man/chdman.1 \
+            ${worksrcpath}/docs/man/floptool.1 \
+            ${worksrcpath}/docs/man/imgtool.1 \
+            ${worksrcpath}/docs/man/jedutil.1 \
+            ${worksrcpath}/docs/man/ldresample.1 \
+            ${worksrcpath}/docs/man/ldverify.1 \
+            ${worksrcpath}/docs/man/romcmp.1 ${destroot}${prefix}/share/man/man1
+    }
 }

 # Universal variant is untested

Attachments (2)

Portfile (4.1 KB) - added by rhuelga (Roberto Huelga) 4 years ago.
Portfile mame with +tools variant
Portfile-mame.diff (1.3 KB) - added by rhuelga (Roberto Huelga) 4 years ago.
Patch mame portfile

Download all attachments as: .zip

Change History (17)

Changed 4 years ago by rhuelga (Roberto Huelga)

Attachment: Portfile added

Portfile mame with +tools variant

comment:1 Changed 4 years ago by rhuelga (Roberto Huelga)

Description: modified (diff)

comment:2 Changed 4 years ago by mf2k (Frank Schima)

Thanks. Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing. Or better yet, submit a GitHub pull request.

I see no reason to make this a variant. Just always do that.

Version 0, edited 4 years ago by mf2k (Frank Schima) (next)

Changed 4 years ago by rhuelga (Roberto Huelga)

Attachment: Portfile-mame.diff added

Patch mame portfile

comment:3 Changed 4 years ago by rhuelga (Roberto Huelga)

Description: modified (diff)

comment:4 Changed 4 years ago by mascguy (Christopher Nielsen)

Cc: mascguy added

comment:5 Changed 4 years ago by mascguy (Christopher Nielsen)

As part of upgrading the Mame port to 0.226, we'll include this functionality as well.

Tracked by: issue:61482

comment:6 Changed 4 years ago by mascguy (Christopher Nielsen)

These changes have been included in the pull request for Mame 0.226:

https://github.com/macports/macports-ports/pull/9314

comment:7 Changed 4 years ago by mascguy (Christopher Nielsen)

Can someone assign this ticket to me? (I don't have permission to modify other folks' tickets.)

Thanks, -Chris

comment:8 Changed 4 years ago by mf2k (Frank Schima)

Cc: mascguy removed
Owner: set to mascguy
Status: newassigned

comment:9 Changed 4 years ago by mascguy (Christopher Nielsen)

Thanks Frank!

comment:10 Changed 4 years ago by mascguy (Christopher Nielsen)

This work has been fully incorporated into the Mame 0.226 port update, and will be available shortly.

Note that the 'tools' variant is enabled by default.

comment:11 Changed 4 years ago by mascguy (Christopher Nielsen)

Roberto, once you've upgraded to Mame 0.226 (and tested the tools), let me know if all is well. Feedback welcome!

Last edited 4 years ago by mascguy (Christopher Nielsen) (previous) (diff)

comment:12 Changed 4 years ago by mascguy (Christopher Nielsen)

There are just two caveats to keep in mind:

  • The Mame tools aren't yet soft-linked into ${prefix}/bin. As such, you'll need to run them directly via ${prefix}/libexec/mame/<tool-name>. (Or you can simply add ${prefix}/libexec/mame to your path for now.)
  • Man pages for the tools aren't yet installed.

Both items are being tracked by issue:61739, and will be taken care of with the next release. (Expected before the end of December.)

Last edited 4 years ago by mascguy (Christopher Nielsen) (previous) (diff)

comment:13 Changed 4 years ago by mascguy (Christopher Nielsen)

The two caveats mentioned previously -- the lack of soft links in ${prefix}/bin, and missing man pages -- will both be resolved with the following:

https://github.com/macports/macports-ports/pull/9446

comment:14 Changed 4 years ago by mascguy (Christopher Nielsen)

Pull request approved and merged. This ticket can be closed.

comment:15 Changed 4 years ago by kencu (Ken)

Resolution: fixed
Status: assignedclosed

thanks for your time, as always!

Note: See TracTickets for help on using tickets.