gsed 4.9 fails to build with gcc-4.2 (10.5.8, 10.6.8)

[barracuda156]

sed/compile.c: In function 'bad_command':
sed/compile.c:206: error: #pragma GCC diagnostic not allowed inside functions
sed/compile.c:207: error: #pragma GCC diagnostic not allowed inside functions
sed/compile.c:209: error: #pragma GCC diagnostic not allowed inside functions
make[2]: *** [sed/sed-compile.o] Error 1

[Schamschula (Marius Schamschula)]

Maybe need to use a different compiler?

[barracuda156]

Replying to Schamschula:

Maybe need to use a different compiler?

Unless those are patched out, we need to blacklist ancient compilers. (I do not want to make a PR for this myself, because a) maybe there is a better solution that blacklist and b) I have too many PRs open which no one helps to merge LOL.)

[Schamschula (Marius Schamschula)]

I have no way of testing this other than blindly committing possible solutions. My oldest active OS in Big Sur. PRs are welcome.

[kencu (Ken)]

1 or 2 places, patch out when building w gcc. More than that, blacklist older gccs.

Then test it to make sure it actually runs.

Then PR it with proof it works and you’ll see it committed faster.

[ballapete (Peter "Pete" Dyballa)]

The same error happens on PPC Mac OS X 10.5.8, Leoprad.

[ballapete (Peter "Pete" Dyballa)]

Easy workaround is to remove the three #pragma lines.

[ballapete (Peter "Pete" Dyballa)]

Possible patch for use by old compilers

[barracuda156]

Replying to ballapete:

Easy workaround is to remove the three #pragma lines.

Maybe you make a PR?

[ballapete (Peter "Pete" Dyballa)]

What is a "PR"? Patch Request? Another option is to use a more up-to-date C compiler. It's up to the maintainer to decide which way is easier (for me it's the latter).