Changes between Initial Version and Version 1 of Ticket #67446, comment 5
- Timestamp:
- Aug 19, 2023, 12:21:04 PM (14 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #67446, comment 5
initial v1 2 2 > Looks like `-nostdinc++` is being added by the legacysupport 1.1 portgroup when `legacysupport.use_mp_libcxx yes` is set. It puts the flag into CPPFLAGS, which would get passed to both C and C++ compilers, so I'm not sure if that's right. Chris, you [changeset:00df9e8ac7d2393e66553bcd99e68d954a771d48/macports-ports added the flag] to fix [ticket:63869 this issue] but in the issue description you suggested adding the flags to CXXFLAGS, not CPPFLAGS. 3 3 4 If `CXXFLAGS` is the preferred way to do this, we can certainly change it. With the caveat that I'd want to test locally with the change - on an older macOS release s, to ensure `macports-libcxx` comes into play - for everything that currently depends on it.4 If `CXXFLAGS` is the preferred way to do this, we can certainly change it. With the caveat that I'd want to test locally with the change - on an older macOS release, to ensure `macports-libcxx` comes into play - for everything that currently depends on it. 5 5 6 6 That being said, I'm always nervous about changing something like this, given that it doesn't cause issues for anything else. (At least, not that I'm currently aware of.)