Changes between Initial Version and Version 1 of Ticket #69362, comment 2


Ignore:
Timestamp:
Apr 11, 2024, 11:26:05 AM (6 months ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #69362, comment 2

    initial v1  
    44> I see that I was the one who [changeset:636bc5899e50c7b8550e4919739a5a1d49502df0/macports-ports made this mistake].
    55
    6 To be fair, cantera says you can do this:
    7 
    8 https://github.com/Cantera/cantera/blob/3e036b7c84f5ae77bf529a801d9db850b570db73/SConstruct#L69-L71
    9 
    10 and I must have tested that it worked before I committed it. I guess it used to work in an old version of scons (at the time, MacPorts had scons 3.1.2) and doesn't work anymore in the current version (at the time of filing this ticket, MacPorts had scons 4.6.0).
     6To be fair, [https://github.com/Cantera/cantera/blob/3e036b7c84f5ae77bf529a801d9db850b570db73/SConstruct#L69-L71 cantera says you can do this] and I must have tested that it worked before I committed it. I guess it used to work in an old version of scons (at the time, MacPorts had scons 3.1.2) and doesn't work anymore in the current version (at the time of filing this ticket, MacPorts had scons 4.6.0).