qt5-qtwebengine @5.15.16_2 : converts to incompatible function type on sequoia

[m0nt0 (Pietro Montorfano)]

while installing openconect-sso qt-webengine is a dependency. The build fails on sequoia

--->  Building qt5-qtwebengine
Error: Failed to build qt5-qtwebengine: command execution failed
Error: See /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_aqua_qt5/qt5-qtwebengine/main.log for details.
Error: Follow https://guide.macports.org/#project.tickets if you believe there is a bug.
Error: Processing of port openconnect-sso failed

the error seems to be

:info:build ../../3rdparty/chromium/third_party/harfbuzz-ng/src/src/hb-ft.cc:759:73: error: cast from 'void (*)(FT_Face)' (aka 'void (*)(FT_FaceRec_ *)') to 'FT_Generic_Finalizer' (aka 'void (*)(void *)') converts to incompatible function type [-Werror,-Wcast-function-type-strict]
:info:build   759 |   if (unlikely (!ft_face->generic.data || ft_face->generic.finalizer != (FT_Generic_Finalizer) hb_ft_face_finalize))
:info:build       |                                                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ../../3rdparty/chromium/third_party/harfbuzz-ng/src/src/hb.hh:234:46: note: expanded from macro 'unlikely'
:info:build   234 | #define unlikely(expr) (__builtin_expect (!!(expr), 0))
:info:build       |                                              ^~~~
:info:build ../../3rdparty/chromium/third_party/harfbuzz-ng/src/src/hb-ft.cc:765:34: error: cast from 'void (*)(FT_Face)' (aka 'void (*)(FT_FaceRec_ *)') to 'FT_Generic_Finalizer' (aka 'void (*)(void *)') converts to incompatible function type [-Werror,-Wcast-function-type-strict]
:info:build   765 |     ft_face->generic.finalizer = (FT_Generic_Finalizer) hb_ft_face_finalize;
:info:build       |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build ../../3rdparty/chromium/third_party/harfbuzz-ng/src/src/hb-ft.cc:1035:32: error: cast from 'void (*)(FT_Face)' (aka 'void (*)(FT_FaceRec_ *)') to 'FT_Generic_Finalizer' (aka 'void (*)(void *)') converts to incompatible function type [-Werror,-Wcast-function-type-strict]
:info:build  1035 |   ft_face->generic.finalizer = (FT_Generic_Finalizer) _release_blob;
:info:build       |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build 3 errors generated.

standard macport installation

[m0nt0 (Pietro Montorfano)]

build log

[markemer (Mark Anderson)]

This is also happening on the CI on macOS 12, 13, 14 as well.

[markemer (Mark Anderson)]

I fixed your problem here ​PR-25973, but so many more keep popping up.

[markemer (Mark Anderson)]

Ok, I'm wrong about 12,13,14 - the CI builds are failing for other reasons.

[ryandesign (Ryan Carsten Schmidt)]

Your proposed fix silences the warnings. Instead, can we fix the problems the warnings are pointing out? For example, the harfbuzz problem is fixed by this upstream commit I think:

​https://github.com/harfbuzz/harfbuzz/commit/d88269c827895b38f99f7cf741fa60210d4d5169

[markemer (Mark Anderson)]

Replying to ryandesign:

Your proposed fix silences the warnings. Instead, can we fix the problems the warnings are pointing out? For example, the harfbuzz problem is fixed by this upstream commit I think:

​https://github.com/harfbuzz/harfbuzz/commit/d88269c827895b38f99f7cf741fa60210d4d5169

Awesome - yeah I can do that - thought of making that fix having not seen this, but wasn't sure if that would cause new problems, but fixing is always better than hiding.

[markemer (Mark Anderson)]

I'm wondering how we pick the chromium - we seem to use a random SHA that I don't understand - a lot of these fixes have been fixed upstream, and I'm wondering if we can update rather than patch. Bumping to 5.15.17(webengine only) was trivial, but I don't know how and if I can bump that SHA.

[markemer (Mark Anderson)]

Aha, found it, gonna give this a try. ​https://code.qt.io/cgit/qt/qtwebengine.git/commit/?h=5.15&id=16b714e29a15d2e22d80243cebc1030b1cb59641

[markemer (Mark Anderson)]

I think I mostly have it - but for some reason the patches in ​PR-25973 are failing on the CIs and on my fresh mac VMs. Gonna need to figure out why.