xar @1.8.0.498: error: use of undeclared identifier 'XAR_CKSUM_SHA256', 'XAR_CKSUM_SHA512'

[0xbf00 (Jakob)]

xar @1.8.0.498 fails to build on 10.5. It likely fails to build for all Mac OS X versions <= 10.9.

This appears to be a straightforward regression from #64842

The last commit to the patch files here ([f25b28b7a0911f100870d702b258a2911341fe82/macports-ports]) removed the fix that #64842 (find it here: [910521d9f3c891a6aa147f59890a10603968093d/macports-ports])

Happy to provide logs from my system, but as I get the exact same error that's mentioned in the older ticket, I'm omitting them for now.

Assignment based on GitHub commit authorship and assignment in the linked issue.

[Schamschula (Marius Schamschula)]

That 'fix' no longer works for the current version of xar.

As I attempted to revert older macOS versions to the previous version of xar I must have missed adding it back.

[Schamschula (Marius Schamschula)]

I did add the old patch as patch-src-xar_internal.h.old.diff specifically to support older OS versions.

Looking at the build bot output: It seems to ignore the if statements and pick up the incorrect version number and patch file.

On further investigation: Big Sur and Monterey have a different issue with implicit function declarations. I will have to fix those separately.

[Schamschula (Marius Schamschula)]

See: [9df0a503e8490c0bb7eda2af37c6cfd9df0c9e89/macports-ports]