Opened 15 years ago

Closed 14 years ago

#20918 closed submission (fixed)

New port: cppcheck

Reported by: alek.silverstone@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: jpo@…, paj-macports@…, raimue (Rainer Müller), nerdling (Jeremy Lavergne)
Port: cppcheck

Attachments (5)

Portfile (1.3 KB) - added by paj-macports@… 14 years ago.
Initial version of Portfile for v1.44. Patch required.
patch-Makefile.diff (361 bytes) - added by paj-macports@… 14 years ago.
Patch to Makefile for correct binary installation.
Portfile.2 (1.3 KB) - added by paj-macports@… 14 years ago.
Added Portfile for v1.45 (no patch required)
Portfile.3 (1.2 KB) - added by paj-macports@… 14 years ago.
Fixed Short Description and Compiler, as per raimue's feedback.
Portfile.4 (1.4 KB) - added by raimue (Rainer Müller) 14 years ago.
includes man page

Download all attachments as: .zip

Change History (20)

comment:1 Changed 15 years ago by jpo@…

Cc: jpo@… added

Cc Me!

comment:2 Changed 15 years ago by jpo@…

The correct home page should be:

comment:3 Changed 15 years ago by alek.silverstone@…

Oops, sure, astyle is a different program.

comment:4 Changed 15 years ago by jpo@…

In order to compile the cppcheck command line tool in Leopard (10.5.8 with gcc 4.0.1) I had to disable the gcc -Wlogical-op flag

--- Makefile.orig       2010-03-09 18:07:43.000000000 +0000
+++ Makefile    2010-04-04 20:50:04.000000000 +0100
@@ -1,4 +1,4 @@
-CXXFLAGS=-Wall -Wextra -pedantic -Wfloat-equal -Wcast-qual -Wlogical-op -O2 -DNDEBUG
+CXXFLAGS=-Wall -Wextra -pedantic -Wfloat-equal -Wcast-qual  -O2 -DNDEBUG
 CXX=g++
 BIN=${DESTDIR}/usr/bin

otherwise the build process would terminate with the following error message:

cc1plus: error: unrecognized command line option "-Wlogical-op"

comment:5 Changed 15 years ago by jpo@…

The man page and the pdf manual creation also need to be tweaked:

Makefile: Use /opt/local/share/xsl/docbook-xsl/manpages/docbook.xsl instead.

man/buildman.sh: Use /opt/local/share/xsl/docbook-xsl/xhtml/docbook.xsl and /opt/local/share/xsl/docbook-xsl/fo/docbook.xsl instead.

comment:6 Changed 14 years ago by paj-macports@…

Cc: paj-macports@… added

Cc Me!

Changed 14 years ago by paj-macports@…

Attachment: Portfile added

Initial version of Portfile for v1.44. Patch required.

Changed 14 years ago by paj-macports@…

Attachment: patch-Makefile.diff added

Patch to Makefile for correct binary installation.

comment:7 Changed 14 years ago by paj-macports@…

Have attached files to add cppcheck to macports.

port lint --nitpick

Returns no warnings nor errors.

Am happy to maintain this port.

comment:8 Changed 14 years ago by mf2k (Frank Schima)

Keywords: new request removed
Type: requestsubmission

Changed 14 years ago by paj-macports@…

Attachment: Portfile.2 added

Added Portfile for v1.45 (no patch required)

comment:9 Changed 14 years ago by raimue (Rainer Müller)

Cc: raimue@… added

The description field should be short, about one sentence to say what the purpose of the port is.

The port is not UsingTheRightCompiler, add build.args CXX=${configure.cxx} to the Portfile.

Changed 14 years ago by paj-macports@…

Attachment: Portfile.3 added

Fixed Short Description and Compiler, as per raimue's feedback.

comment:10 Changed 14 years ago by paj-macports@…

Fixed. Thanks for the feedback and the link.

Changed 14 years ago by raimue (Rainer Müller)

Attachment: Portfile.4 added

includes man page

comment:11 Changed 14 years ago by raimue (Rainer Müller)

Here is an update which includes the man page. I also re-ordered some of the options to be in our typical Portfile style (order of execution: configure, build, (test), destroot).

comment:12 Changed 14 years ago by paj-macports@…

Thanks for adding the man page, raimue. I was still working out how to do that!

comment:13 Changed 14 years ago by nerdling (Jeremy Lavergne)

Cc: snc@… added

Is it ready to go into the repo?

comment:14 Changed 14 years ago by paj-macports@…

I'm happy for it to go in.

comment:15 Changed 14 years ago by nerdling (Jeremy Lavergne)

Resolution: fixed
Status: newclosed

Committed in r72324.

Note: See TracTickets for help on using tickets.