Opened 15 years ago

Closed 15 years ago

#24258 closed update (fixed)

Gramps version 3.2.0 Please commit

Reported by: guy.linton@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 1.8.2
Keywords: Cc: ryandesign (Ryan Carsten Schmidt), ctempleton3@…, rjt-gramps@…, lkraider (Paul Eipper), dbevans (David B. Evans)
Port: Gramps

Description

Please find attached a Portfile for Gramps version 3.2.0.

I have tested this on Mac OS X 10.4.11 on an iMac iSight (2.1 GHx PowerPC G5).

rjt-gramps is no longer maintaining this port, so I have specified the maintainer as 'nomaintainer'. (The current version of Gramps on MacPorts is version 3.0.4).

Attachments (2)

Portfile (2.1 KB) - added by guy.linton@… 15 years ago.
Portfile for Gramps 3.2.0
gramps-3.2.0.diff (2.1 KB) - added by ryandesign (Ryan Carsten Schmidt) 15 years ago.
proposed patch

Download all attachments as: .zip

Change History (5)

Changed 15 years ago by guy.linton@…

Attachment: Portfile added

Portfile for Gramps 3.2.0

comment:1 Changed 15 years ago by tobypeterson

Cc: toby@… removed
  • Don't CC a ton of people on random bugs.
  • Testing on Tiger/PPC is not acceptable, this needs to be tested on a supported config (preferably, Snow Leopard/x86_64)

comment:2 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

In future, please submit unified diffs, not complete portfiles, and ensure that the diff only makes changes that are relevant to the task at hand; don't also make unrelated changes, such as whitespace changes.

The $Id$ line in your new portfile indicates revision 28793; I thus assume you based your new version on that old version. You should base your changes on the very latest version of a portfile, in this case 51955. In this case, for example, your "new" portfile undoes changes made to this port previously, such as the livecheck fix from r42705 and the dependency removal from r51955. (Granted, the livecheck doesn't currently work right either way.) Your changes to the description also introduce a typo (advised => adviced).

I've attached a patch which I believe expresses your intent in upgrading the port without the other changes. It installs OK for me on Snow Leopard. I have asked for confirmation from rjt about giving up maintainership of this port; waiting to hear back before committing.

Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: gramps-3.2.0.diff added

proposed patch

comment:3 Changed 15 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: newclosed

Richard Taylor (rjt) confirmed he's giving up the port; marked as nomaintainer in r65601.

Committed my patch to update to 3.2.0 in r65602.

Converted tabs to spaces in r65603.

Fixed livecheck in r65604.

Thanks for the update! If you'd like to become the maintainer of this port, let me know.

Note: See TracTickets for help on using tickets.