Opened 13 years ago

Closed 12 years ago

#32672 closed defect (fixed)

vobcopy: build fails when using clang and running 64-bit kernel

Reported by: philipp@… Owned by: 0booo5b02@…
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: clang haspatch Cc: posita (Matt Bogosian), amadeus24, ryandesign (Ryan Carsten Schmidt)
Port: vobcopy

Description (last modified by mf2k (Frank Schima))

I'm on OS X Lion 10.7.2 with Xcode 4.2.1, i7 processor.

(Apple clang version 3.0 (tags/Apple/clang-211.12) (based on LLVM 3.0svn))

As far as I have found (tried to build the sources myself with all dependencies built from macports), the configure script writes a wrong library path to the Makefile:

LDFLAGS += -ldvdread -L/opt/local/lib64

If I change this to /opt/local/lib vobcopy will build and install just fine.

Attachments (1)

vobcopy.diff (891 bytes) - added by ryandesign (Ryan Carsten Schmidt) 13 years ago.
proposed patch

Download all attachments as: .zip

Change History (8)

comment:1 Changed 13 years ago by philipp@…

Cc: philipp@… added

Cc Me!

comment:2 Changed 13 years ago by mf2k (Frank Schima)

Cc: philipp@… removed
Description: modified (diff)
Owner: changed from macports-tickets@… to 0booo5b02@…

comment:3 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Summary: vobcopy will not buildvobcopy: build fails on Macs running 64-bit kernel

The hand-made configure.sh script has this code which is not correct for OS X:

elif [ `uname -m` = x86_64 ]; then #for ia64/AMD64 libraries
	LDFLAGS="LDFLAGS += -ldvdread -L$libs_dir/lib64"
else
	LDFLAGS="LDFLAGS += -ldvdread -L$libs_dir/lib"
fi

The problem is only visible when running the 64-bit kernel (otherwise uname -m would return i386).

Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Attachment: vobcopy.diff added

proposed patch

comment:4 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Keywords: clang haspatch added
Summary: vobcopy: build fails on Macs running 64-bit kernelvobcopy: build fails when using clang and running 64-bit kernel

The problem also does not manifest unless you're using Xcode 4.2 or greater, since that's the first version of Xcode with which MacPorts defaults to the clang compiler, and that's the only compiler that doesn't use the CPATH and more importantly LIBRARY_PATH variables which otherwise would have taken care of telling the build where to find the library.

Anyway a simple patch to fix this is attached. 0booo5b02, let me know if you have any objections or whether I may commit it.

comment:5 Changed 12 years ago by posita (Matt Bogosian)

Cc: mtb19@… added

Cc Me!

comment:6 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ag@… added

Has duplicate #35026.

comment:7 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added
Resolution: fixed
Status: newclosed

r94810 (maintainer timeout)

Note: See TracTickets for help on using tickets.