Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#33236 closed submission (fixed)

New port: jpegoptim

Reported by: jingoro@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.0.3
Keywords: Cc:
Port: jpegoptim

Description

Please add jpegoptim to MacPorts.

Attachments (1)

Portfile (875 bytes) - added by jingoro@… 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by jingoro@…

Attachment: Portfile added

comment:1 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Port: jpegoptim added
Status: newassigned

Thanks.

comment:2 Changed 13 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

I committed it in r89845 with these changes:

  • Adjusted whitespace to 4 spaces per indent
  • Added standard modeline
  • Set the maintainers field to your complete email address, in our obfuscated format
  • Changed the license field to "GPL-2+" because the source says "or (at your option) any later version"
  • Switched to rmd160 and sha256 checksum types
  • Removed configure.cppflags and configure.ldflags because the values you specified are the defaults MacPorts automatically sets for all ports
  • Removed "--with-libjpeg=${prefix}/lib" from configure.args because that's not correct (should have been "--with-libjpeg=${prefix}") and isn't necessary because of the existing cppflags and ldflags
  • Removed "--prefix=${destroot}${prefix}" from configure.args because MacPorts already puts "--prefix=${prefix}" in configure.pre_args for you, and although the software's Makefile does not support the DESTROOT variable MacPorts sets, it supports the INSTALL_ROOT variable which it uses for the same purpose, so I set "destroot.destdir INSTALL_ROOT=${destroot}" instead

comment:3 Changed 13 years ago by jingoro@…

Thanks Ryan. The feedback is much appreciated.

Note: See TracTickets for help on using tickets.