Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#38317 closed update (fixed)

silo: upgrade to 4.9

Reported by: kurtjaeke@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: silo

Description

Please upgrade port silo to version 4.9.

Changes:

  • when depending on hdf5, also depend on szip
  • --disable-qt does not exist anymore, disable browser and silex instead (which use Qt)

Attachments (2)

silo.diff (1.4 KB) - added by kurtjaeke@… 12 years ago.
silo Portfile patch to upgrade to 4.9.
silo-2.diff (1.1 KB) - added by kurtjaeke@… 12 years ago.
Updated patch for silo.

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by kurtjaeke@…

Attachment: silo.diff added

silo Portfile patch to upgrade to 4.9.

comment:1 Changed 12 years ago by mf2k (Frank Schima)

Version: 2.1.3

The revision line needs to be removed.

comment:2 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Are you certain that the szip dependency should be added in the +hdf5 variant? Does silo itself require szip functions, or are they only used via hdf5-18's interface to them? hdf5-18 can be compiled with or without szip support, via its +szip variant, and the default is off. Can we leave it up to the hdf5-18 port to be in charge of whether szip is used, or does silo really require hdf5-18 with szip support? If the latter, we might want to use the active_variants portgroup to do that.

comment:3 in reply to:  2 Changed 12 years ago by kurtjaeke@…

The source code looks like silo uses only the HDF5 API to detect the compression (src/hdf5_drv/silo_hdf5.c, lines 3112 and following), so the dependency on szip can go away.

I'll attach a new patch.

Changed 12 years ago by kurtjaeke@…

Attachment: silo-2.diff added

Updated patch for silo.

comment:4 Changed 12 years ago by kurtjaeke@…

Cc: kurtjaeke@… added

Cc Me!

comment:5 Changed 12 years ago by kurtjaeke@…

Any news?

comment:6 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: kurtjaeke@… removed
Keywords: haspatch added
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

comment:7 Changed 12 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: fixed
Status: assignedclosed

comment:8 Changed 12 years ago by kurtjaeke@…

Thanks!

Note: See TracTickets for help on using tickets.