Opened 11 years ago
Closed 7 years ago
#39032 closed defect (fixed)
libnotify @0.5.2 should use the active_variants portgroup
| Reported by: | cooljeanius (Eric Gallager) | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.1.3 |
| Keywords: | Cc: | kurthindenburg (Kurt Hindenburg) | |
| Port: | libnotify |
Description
Building libnotify without its +quartz variant while gtk2 is installed with +quartz results in the following error:
notification.c:29:10: fatal error: 'gdk/gdkx.h' file not found
#include <gdk/gdkx.h>
^
1 error generated.
make[3]: *** [notification.lo] Error 1
make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libnotify/libnotify/work/libnotify-0.5.2/libnotify'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libnotify/libnotify/work/libnotify-0.5.2/libnotify'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libnotify/libnotify/work/libnotify-0.5.2'
make: *** [all] Error 2
make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libnotify/libnotify/work/libnotify-0.5.2'
Command failed: cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_devel_libnotify/libnotify/work/libnotify-0.5.2" && /usr/bin/make -j4 -w all
Exit code: 2
<gdk/gdkx.h> is only installed with the +x11 variant of gtk2. Therefore, libnotify should use the active_variants portgroup to check for this variant.
(libnotify has no maintainer so anyone can fix this)
Attachments (1)
Change History (7)
comment:1 follow-up: 2 Changed 11 years ago by larryv (Lawrence Velázquez)
comment:2 Changed 11 years ago by cooljeanius (Eric Gallager)
comment:3 Changed 11 years ago by cooljeanius (Eric Gallager)
Hm, it appears there's an update to version 0.7.5 as well... although upon updating the portfile, it looks like it uses gtk3 now instead of gtk2, and the quartz patch doesn't apply anymore...
Changed 11 years ago by cooljeanius (Eric Gallager)
| Attachment: | notification.c.rej added |
|---|
failed patch for notification.c
comment:5 Changed 11 years ago by cooljeanius (Eric Gallager)
My work-in-progress portfile can be found at https://github.com/cooljeanius/LocalPorts/blob/master/devel/libnotify/Portfile... will generate patches once I get some other stuff worked out...
comment:6 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)
| Cc: | kurthindenburg added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
This should be fixed in current version
Replying to egall@…:
Or you could attach a patch.