Opened 10 years ago

Closed 10 years ago

#46482 closed defect (fixed)

p5-sysadm-install: requires p5-expect to use provided function hammer()

Reported by: dbevans (David B. Evans) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mojca (Mojca Miklavec)
Port: p5-sysadm-install

Description (last modified by dbevans (David B. Evans))

A dependency on p5-expect seems to be required for full functionality.

Configure warns as follows:

DEBUG: Assembled command: 'cd "/opt/local/var/macports/build/_opt_macports_trunk_dports_perl_p5-sysadm-install/p5.20-sysadm-install/work/Sysadm-Install-0.44" && /opt/local/bin/perl5.20 Makefile.PL INSTALLDIRS=vendor CC="/usr/bin/clang" LD="/usr/bin/clang"'
DEBUG: Executing command line:  cd "/opt/local/var/macports/build/_opt_macports_trunk_dports_perl_p5-sysadm-install/p5.20-sysadm-install/work/Sysadm-Install-0.44" && /opt/local/bin/perl5.20 Makefile.PL INSTALLDIRS=vendor CC="/usr/bin/clang" LD="/usr/bin/clang" 
WARNING: Expect not found.
         You won't be able to use hammer().
         Install Expect from CPAN later if you want to.
Checking if your kit is complete...
Looks good

Tests don't seem to cover this functionality but without p5.20-expect active

$ perl5.20
use Sysadm::Install qw(:all);
hammer("man", "portfile");
__END__
Can't locate Expect.pm in @INC (you may need to install the Expect module) (@INC contains: /opt/local/lib/perl5/site_perl/5.20/darwin-thread-multi-2level /opt/local/lib/perl5/site_perl/5.20 /opt/local/lib/perl5/vendor_perl/5.20/darwin-thread-multi-2level /opt/local/lib/perl5/vendor_perl/5.20 /opt/local/lib/perl5/5.20/darwin-thread-multi-2level /opt/local/lib/perl5/5.20 .) at /opt/local/lib/perl5/vendor_perl/5.20/Sysadm/Install.pm line 1385.

Change History (3)

comment:1 Changed 10 years ago by dbevans (David B. Evans)

Description: modified (diff)

comment:2 Changed 10 years ago by mojca (Mojca Miklavec)

The author replied:

It's optional.

The test suite will succeed if it's missing, but the hammer() function won't be supported.

comment:3 Changed 10 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed

I vote to support it since it's described in the documentation with no caveats. Dependency on p5-expect added in r131290.

Note: See TracTickets for help on using tickets.