Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#53166 closed defect (fixed)

yarn: default to an older nodejs on 10.6

Reported by: mojca (Mojca Miklavec) Owned by: jambonrose (Andrew Pinkham)
Priority: Normal Milestone:
Component: ports Version:
Keywords: snowleopard Cc: isomarcte (David Strawn), ci42
Port: yarn

Description (last modified by mojca (Mojca Miklavec))

nodejs6 only seems to work on 10.7 and later (see also #53165 and many other tickets).

Based on comments in the portfiles it seems that nodejs4 and 5 require at least 10.6 and nodejs requires at least 10.7. It would be nice to fallback to an older version of nodejs (perhaps version 5) on < 10.7.

Btw: is the isomarcte's email in Yarn misspelled?

Change History (9)

comment:1 Changed 8 years ago by mojca (Mojca Miklavec)

Description: modified (diff)
Keywords: lion removed
Summary: yarn: default to an older nodejs on < 10.8yarn: default to an older nodejs on 10.6

comment:2 Changed 8 years ago by jambonrose (Andrew Pinkham)

I've opened a PR on Github that attempts to fix this issue: https://github.com/macports/macports-ports/pull/127

comment:3 Changed 8 years ago by jambonrose (Andrew Pinkham)

Resolution: fixed
Status: newclosed

In d82c06f2/macports-ports:

yarn: use older NodeJS on <= 10.6, typo in email

Fix a typo in maintainer's email

Node JS 6 cannot be installed on Mac OS X 10.6 (Snow Leopard)
and earlier. This change checks the major OS version and uses
Node JS version 4 when appropriate.

Closes: #53166

comment:4 Changed 8 years ago by mojca (Mojca Miklavec)

In 19b2d744/macports-ports:

npm: use an older nodejs on < 10.7

See: #53166

comment:5 Changed 8 years ago by mojca (Mojca Miklavec)

In 02fbf17/macports-ports:

npm3, npm4: fix path-style dependency on nodejs

Fixes an incorrect dependency replacement
introduced with 19b2d7444a (https://github.com/macports/macports-ports/pull/128).

See: #53166

comment:6 Changed 8 years ago by mojca (Mojca Miklavec)

In 5b6de0c7/macports-ports:

yarn: fix path-style dependency on nodejs

See: #53166

comment:7 Changed 8 years ago by jambonrose (Andrew Pinkham)

Thanks for the fix!

Quick question: the dependency is set with depends_run, but commit 5b6de0c7 changes the pre-10.7 code to use depends_lib-replace. Does depends_run-replace not exist?

comment:8 Changed 8 years ago by mojca (Mojca Miklavec)

In 992c4f6c/macports-ports:

yarn: fix dependency replacement

See: #53166

comment:9 Changed 8 years ago by mojca (Mojca Miklavec)

I'm sorry, I suspect it was a copy-and-paste error. Thanks a lot for noticing.

Note: See TracTickets for help on using tickets.