Opened 8 years ago
Closed 7 years ago
#53206 closed update (fixed)
Please update xar to 1.6.1 and/or add ext2 patch
| Reported by: | gallafent | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | Schamschula (Marius Schamschula), kurthindenburg (Kurt Hindenburg) | |
| Port: | xar |
Description
Xar doesn't build for me in its current state, and is _very_ outdated. The xar-devel port exists but is also very outdated.
Attached portfile uses current release from github (rather than obsolescent google code) release, and adds the patch from https://github.com/voidlinux/void-packages/blob/master/srcpkgs/xar/patches/ext2.patch to allow the build to complete.
Attachments (3)
Change History (15)
Changed 8 years ago by gallafent
Changed 8 years ago by gallafent
| Attachment: | patch-ext2.c added |
|---|
Ext2 patch to allow build to complete
comment:1 Changed 8 years ago by mf2k (Frank Schima)
| Cc: | mww@… removed |
|---|---|
| Keywords: | haspatch removed |
| Owner: | set to mww@… |
| Status: | new → assigned |
Thanks. Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing.
comment:2 Changed 8 years ago by Schamschula (Marius Schamschula)
Unfortunately, xar 1.6.1 is also 4 years old...
However, it is newer that xar-devel (@1.6_5).
The port file needed a number of changes:
1) replace $ID$ line with mode line
2) use github PortGroup
3) use worksrcdir
4) remove unused xz dependency
5) use_autoconf
6) remove obsolete configure.args
Changed 8 years ago by Schamschula (Marius Schamschula)
| Attachment: | Portfile.2 added |
|---|
Portfile using GitHub PortGroup
comment:3 Changed 8 years ago by Schamschula (Marius Schamschula)
| Cc: | Schamschula added |
|---|
comment:4 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)
| Owner: | changed from mww@… to macports-tickets@… |
|---|
comment:5 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)
| Cc: | kurthindenburg added |
|---|
What's the consensus here? Try to update the version here to 1.6.1 from above "unofficial" github? and then obsolete xar-devel and update the other ports? py-xar xpkg rmp54
comment:6 Changed 7 years ago by Schamschula (Marius Schamschula)
Well, code.google.com is dead.
Wikipedia https://en.wikipedia.org/wiki/Xar_%28archiver%29 lists
https://github.com/mackyle/xar or http://mackyle.github.io/xar/ as the official home page.
I've been using xar 1.6.1 since I uploaded Portfile.2 on all my machines.
The maintainer line probably needs to be updated, though.
comment:7 Changed 7 years ago by Schamschula (Marius Schamschula)
comment:8 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)
Yeah, I have an update w/ all the pull requests fixing some of the bad code (which appears a lot). mackyle doesn't seem like he has time to work on it.
comment:9 follow-up: 11 Changed 7 years ago by kurthindenburg (Kurt Hindenburg)
and I meant to add - I would suggest you can commit your changes - there are a few lines I don't understand why are there.
comment:10 Changed 7 years ago by Schamschula (Marius Schamschula)
I hope those PRs also address
CVE-2017-11124 and CVE-2017-11125
http://www.cvedetails.com/vulnerability-list/vendor_id-16654/product_id-38736/Xar-Project-XAR.html
comment:11 Changed 7 years ago by Schamschula (Marius Schamschula)
Replying to kurthindenburg:
and I meant to add - I would suggest you can commit your changes - there are a few lines I don't understand why are there.
Such as?
comment:12 Changed 7 years ago by Schamschula (Marius Schamschula)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Portfile adapted from those from xar and xar-devel to fetch and build 1.6.1 from github