port:audacity build fix (and upgrade for audacity-devel)

[RJVB (René Bertin)]

Attached 2 patches for port:audacity:

• an updated patchfile that reenables building with the latest cctools installed and on 10.12
• an updated Portfile that pushes a 2.1.3 alpha release.

I don't think that a revbump is required because the port either builds or it doesn't.

[RJVB (René Bertin)]

updated patchfile

[RJVB (René Bertin)]

updated Portfile

[ryandesign (Ryan Carsten Schmidt)]

Please don't override the github portgroup's choice of master_sites. Either use a release download if available, or use a tarball download, or if using an archive download is important to you, fix the github portgroup to offer that choice (#40518).

[RJVB (René Bertin)]

Portfile with upgrade to 6.1.3 / 6.1.3.190

[RJVB (René Bertin)]

full portdir, containing the patchfiles

[RJVB (René Bertin)]

Replying to ryandesign:

or [...] fix the github portgroup to offer that choice (#40518).

Why would I have to fix your portgroup? Fortunately it seems I don't need to override anything (anymore).

I have used the occasion to upgrade the port to 6.1.3 (6.1.3.190 for audacity-devel). The patches were regenerated so I've attached a tarball of the port directory

[mf2k (Frank Schima)]

I tried your latest portfile and patches, but I see this message from the app: "Audacity attempted to use FFmpeg to import an audio file, but the libraries were not found."

I have it installed:

$ port installed ffmpeg-devel 
The following ports are currently installed:
  ffmpeg-devel @20170119_4+gpl2+gpl3+nonfree (active)

[mf2k (Frank Schima)]

In f6dbea67d7d63e7dd7256a90836aaa88c58179d9/macports-ports:

audacity:

• Build fix for latest cctools
• Update to version 2.1.3
• Add audacity-devel

Closes: #53470

[RJVB (René Bertin)]

I don't understand, did you apply the changes even though they didn't solve the issue for you?

Or does it work correctly with the regular port:ffmpeg?

[mf2k (Frank Schima)]

Well it did not build before, so having something build is better than not! That message is still present however. I have not tried with regular ffmpeg.

[RJVB (René Bertin)]

Have you tried pointing Audacity to your FFmpeg install via the preferences dialog? It's not completely impossible that it simply fails to disregard an old config.

[mf2k (Frank Schima)]

I see that in the ​docs now. Thanks! Calling it user error. Adding a note in the notes section might be helpful though. Same for mp3 and lame library. I had to set that too. Maybe lame should be a library dependency?

[RJVB (René Bertin)]

"MP3 AND lame" or do you mean "same for the lame library for MP3 functionality"? I've never seen that one act up but I guess the runtime resolution is vulnerable to the same glitches as the FFmpeg resolution.

I don't have commit rights, maybe you could add the following at an appropriate location in the Portfile (after the long_description seems fine):

notes "In case Audacity complains about finding FFmpeg or Lame, please locate these libraries\
under ${prefix}/lib in the Libraries section of the Preferences dialog (see\
http://manual.audacityteam.org/man/installing_and_updating_audacity_on_mac_os_x.html#locate)."

Lame is already a build dependency. It's small enough and doesn't have a whole list of dependencies itself so making it a "complete" dependency (or adding an additional runtime dependency) shouldn't make a big difference even for users who'll never open a single .mp3 file.

BTW, is there any practical difference between declaring a dependency with a single depends_lib or the pair depends_build + depends_run?

[mf2k (Frank Schima)]

Replying to RJVB:

"MP3 AND lame" or do you mean "same for the lame library for MP3 functionality"? I've never seen that one act up but I guess the runtime resolution is vulnerable to the same glitches as the FFmpeg resolution.

Yes, that is what I meant. It was not finding lame automatically when I installed it.

I don't have commit rights, maybe you could add the following at an appropriate location in the Portfile (after the long_description seems fine):

notes "In case Audacity complains about finding FFmpeg or Lame, please locate these libraries\
under ${prefix}/lib in the Libraries section of the Preferences dialog (see\
http://manual.audacityteam.org/man/installing_and_updating_audacity_on_mac_os_x.html#locate)."

Will do.

BTW, is there any practical difference between declaring a dependency with a single depends_lib or the pair depends_build + depends_run?

It is pretty much the same. Using depends_lib is preferred so it does not need to be declared twice.

[mf2k (Frank Schima)]

In 5787dba7ac8dae47ab646dfd55ad09c183be975c/macports-ports:

audacity:

• Add notes field about finding FFmpeg and Lame
• Make lame a library dependency because it is a build and runtime dependency

See: #53470

[RJVB (René Bertin)]

Thanks. I was going to say you could feel free to modify the lame depspec too but you beat me to it :)