Opened 7 years ago

Closed 7 years ago

#55286 closed defect (fixed)

gr-lora: Don't change the version in a variant

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: michaelld (Michael Dickens)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: gr-lora

Description

gr-lora changes the version in a variant.

$ port info gr-lora +rpp0 | head -n 1
gr-lora @20170920 (science, comms)
$ port info gr-lora +BastilleResearch | head -n 1
gr-lora @20170713 (science, comms)
$

Ports should not do this because it doesn't work the way users expect. Only the version corresponding to the default variants gets recorded in the portindex, and only the portindex is used when determining if a port is outdated. For example if I install with the +BastilleResearch variant:

$ sudo port install gr-lora +BastilleResearch
--->  Computing dependencies for gr-lora
--->  Fetching archive for gr-lora
--->  Attempting to fetch gr-lora-20170713_0+BastilleResearch.darwin_16.x86_64.tbz2 from https://packages.macports.org/gr-lora
--->  Fetching distfiles for gr-lora
--->  Verifying checksums for gr-lora
--->  Extracting gr-lora
--->  Configuring gr-lora
--->  Building gr-lora
--->  Staging gr-lora into destroot
--->  Installing gr-lora @20170713_0+BastilleResearch
--->  Activating gr-lora @20170713_0+BastilleResearch
--->  Cleaning gr-lora
$

It is currently at an older version than the default +rpp0 variant, so it is immediately considered outdated, but upgrading does nothing:

$ port outdated gr-lora
The following installed ports are outdated:
gr-lora                        20170713_0 < 20170920_0   
$ sudo port upgrade gr-lora
$

On the other hand, if the +BastilleResearch variant were at a newer version than the default +rpp0 variant, the port would not be displayed at all in the output of port outdated even when it is updated and the user would never know about the new version.

If the user really needs to be given the choice of using the rpp0 or BastilleResearch forks, maybe it should be implemented as subports instead of variants.

Change History (1)

comment:1 Changed 7 years ago by michaelld (Michael Dickens)

Resolution: fixed
Status: newclosed

In 324d176d87a2b464e0ecb4aef15cfb1b24468eab/macports-ports:

gr-lora: change variants to subports.

Replace the default gr-lora by gr-lora-rpp0.

Closes: #55286

Note: See TracTickets for help on using tickets.