webkit2-gtk can't build +universal: due to errors in the javascript interpreter error: use of undeclared identifiers 'TagBitsWasm' 'TagWasmMask' 'offsetExtractorTable'

[ryandesign (Ryan Carsten Schmidt)]

Building webkit2-gtk with the +universal variant fails:

Source/JavaScriptCore/interpreter/CalleeBits.h:54:81: error: use of undeclared identifier 'TagBitsWasm'
        CalleeBits result(bitwise_cast<void*>(bitwise_cast<uintptr_t>(callee) | TagBitsWasm));
                                                                                ^
Source/JavaScriptCore/interpreter/CalleeBits.h:63:50: error: use of undeclared identifier 'TagWasmMask'
        return (bitwise_cast<uintptr_t>(m_ptr) & TagWasmMask) == TagBitsWasm;
                                                 ^
Source/JavaScriptCore/interpreter/CalleeBits.h:63:66: error: use of undeclared identifier 'TagBitsWasm'
        return (bitwise_cast<uintptr_t>(m_ptr) & TagWasmMask) == TagBitsWasm;
                                                                 ^
Source/JavaScriptCore/interpreter/CalleeBits.h:80:78: error: use of undeclared identifier 'TagBitsWasm'
        return bitwise_cast<Wasm::Callee*>(bitwise_cast<uintptr_t>(m_ptr) & ~TagBitsWasm);
                                                                             ^
4 errors generated.

Some possibly relevant suggestions at ​https://bugs.webkit.org/show_bug.cgi?id=172799

[kencu (Ken)]

I will admit being moderately surprised that the i386 version built at all, much less +universal !

[kencu (Ken)]

There have been many changes to webkit2-gtk since this ticket came forth, so if anyone uses it +universal please report back whether it is fixed or not. I'm just not going to build webkit2-gtk +universal myself -- no reason to do so at present, and there are too many deps.

[ryandesign (Ryan Carsten Schmidt)]

Problem still exists with 2.26.1:

Source/JavaScriptCore/interpreter/CalleeBits.h:54:89: error: use of undeclared identifier 'TagBitsWasm'
        CalleeBits result(reinterpret_cast<void*>(reinterpret_cast<uintptr_t>(callee) | TagBitsWasm));
                                                                                        ^
Source/JavaScriptCore/interpreter/CalleeBits.h:63:54: error: use of undeclared identifier 'TagWasmMask'
        return (reinterpret_cast<uintptr_t>(m_ptr) & TagWasmMask) == TagBitsWasm;
                                                     ^
Source/JavaScriptCore/interpreter/CalleeBits.h:63:70: error: use of undeclared identifier 'TagBitsWasm'
        return (reinterpret_cast<uintptr_t>(m_ptr) & TagWasmMask) == TagBitsWasm;
                                                                     ^
Source/JavaScriptCore/interpreter/CalleeBits.h:80:86: error: use of undeclared identifier 'TagBitsWasm'
        return reinterpret_cast<Wasm::Callee*>(reinterpret_cast<uintptr_t>(m_ptr) & ~TagBitsWasm);
                                                                                     ^
Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:94:12: error: use of undeclared identifier 'offsetExtractorTable'
    return offsetExtractorTable;
           ^
5 errors generated.

[kencu (Ken)]

It looks like the definitions for the undefined bits are guarded here ​here by a 64 bit guard. Perhaps this code is unable to build +universal for that reason (and might have to use the universal PortGroup, oh gosh, can you imagine?). Alternatively, turning of webassembly is a possibility that might eliminate the use of this code.

[kencu (Ken)]

In 99071bbea2e17d92cabeeae19a0d112b53c5c1ef/macports-ports (master):

webkit2-gtk* : disable universal variant

unable to make this build universal after considerable
attempts. muniversal PG does not fix it. Disabling JIT
does not fix it. Help wanted, if motivated.

see #56792