Opened 5 years ago

Closed 4 years ago

#59980 closed defect (fixed)

qBittorrent: build failure on 10.11; silent rules prevent analysis

Reported by: ryandesign (Ryan Carsten Schmidt) Owned by: i0ntempest
Priority: Normal Milestone:
Component: ports Version: 2.6.2
Keywords: Cc:
Port: qBittorrent

Description

I'm not sure how many OS versions back qBittorrent wants to support, but I see a build failure on 10.11. The error is:

base/bittorrent/peeraddress.cpp:58:12: error: no matching constructor for initialization of 'BitTorrent::PeerAddress'
    return {ip, port};
           ^~~~~~~~~~
base/bittorrent/peeraddress.h:37:12: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided
    struct PeerAddress
           ^
base/bittorrent/peeraddress.h:37:12: note: candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 2 were provided
base/bittorrent/peeraddress.h:37:12: note: candidate constructor (the implicit default constructor) not viable: requires 0 arguments, but 2 were provided
1 error generated.

I wonder if this is related to this prior warning:

./base/tristatebool.h:43:9: warning: use of this statement in a constexpr constructor is a C++14 extension [-Wc++14-extensions]
        *this = boolean ? True : False;
        ^

The port does specify that it requires C++14, but perhaps the build system is not respecting our compiler choice. It's impossible to tell because the build log does not show the actual commands that were run to compile things: the build has some sort of "silent rules" enabled. Is there a way to disable silent rules? Then we can more easily debug further.

If silent rules are a standard Qt feature—if this is a generic problem that affects other ports using the qt5 portgroup—then maybe a fix can go in the qt5 portgroup (just as we have such a fix already in the cmake portgroup).

Change History (4)

comment:1 Changed 4 years ago by i0ntempest

Resolution: fixed
Status: assignedclosed

In e13b0172a35f1bf0a510d6ea4c3b04178ef0b749/macports-ports (master):

qBittorrent: attempt to fix build on 10.11 and earlier (https://github.com/macports/macports-ports/pull/8873)

Closes: #59980

comment:2 Changed 4 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: closedreopened

comment:3 Changed 4 years ago by i0ntempest

Yeah I'll try a few more times later. Also interestingly builds in 10.10 and 10.9 fail due to different reasons. I might try refactoring this to use qmake5 pg.

comment:4 Changed 4 years ago by i0ntempest

Resolution: fixed
Status: reopenedclosed

In 57a512dc9c2e2ef63fcbcc8b3c9ff5cbc36c1b77/macports-ports (master):

qBittorrent: change to qmake5 pg & 2nd try to fix build on 10.11

Will revbump later if it clears buildbots or when I'm done/give up fixing
Closes: #59980

Note: See TracTickets for help on using tickets.