legacy-support-devel @20211026: fish hangs in macports_legacy_realpath

[evanmiller (Evan Miller)]

When I switch from legacy-support 1.0.4 to the latest legacy-support-devel, I cannot start fish (program hangs). Instruments shows this sample report:

# Report 0 - Timed Samples for Unattached
Stacks at 2021-10-27 12:16:52 -0400
Samples (displayed/total): 238/238
Call graph:
    238 Thread_5f03
      238 start
        238 _start
          122 macports_legacy_realpath
            122 macports_legacy_realpath
          116 main
            116 macports_legacy_realpath
              116 macports_legacy_realpath

Total number in stack (recursive counted multiple, when >=5):

Sort by top of stack, same collapsed (when >= 5):
        macports_legacy_realpath        238

I am guessing this wrapped function can be disabled but I'd rather understand the root cause here. Shell starts normally after switching back to legacy-support.

It was a "hot swap" without a rebuild. 10.4.11/PowerPC

[cjones051073 (Chris Jones)]

I was testing yesterday a change in a branch using the devel port (which is there for testing).

​https://github.com/macports/macports-legacy-support/commits/sysconf-wrap-always-defined

I am probably not going to proceed with that change, as it ended up not being the right approach for the issue I had. So I'll update the developers port to use a commit back on the master branch.

[cjones051073 (Chris Jones)]

Please give ​https://github.com/macports/macports-ports/commit/8c309b9bdf567066f8e7659f1fab7eda9240e273 a try ?

[evanmiller (Evan Miller)]

Fixed, thanks

[cjones051073 (Chris Jones)]

Great!