zstd: link failure on 10.4 PPC: common symbols not allowed with MH_DYLIB output format with the -multi_module option

[mascguy (Christopher Nielsen)]

I'm seeing the following link error, when attempting to install this port on 10.4 PPC:

:info:build /usr/bin/ld: common symbols not allowed with MH_DYLIB output format with the -multi_module option
:info:build obj/conf_bf5285a93c681430f8fd86e69930a4b6/dynamic/threading.o private external definition of common _g_ZSTD_threading_useless_symbol (size 4)
:info:build collect2: ld returned 1 exit status
:info:build gmake[2]: *** [Makefile:294: obj/conf_bf5285a93c681430f8fd86e69930a4b6/dynamic/libzstd.1.5.0.dylib] Error 1
:info:build gmake[1]: *** [Makefile:281: libzstd.1.5.0.dylib] Error 2

Reviewed similar tickets with this issue, and there didn't seem to be (?) one right answer/solution.

10.4 aficionados, do you have an easy fix?

[evanmiller (Evan Miller)]

I would suggest installing a newer linker (ld64). I have zstd @1.5.0_0 installed here just fine.

[jmroot (Joshua Root)]

TBH the preferable solution is to compile with -fno-common and fix the code to work that way. That's the default with newer compilers, few people understand what common linkage does, and it's very rare that you actually need it.

[jmroot (Joshua Root)]

:info:build compress/zstd_ldm_geartab.h:15: warning: integer constant is too large for 'long' type

Those warnings are also likely to be unsafe to ignore. Building with -std=c99 might help.

[mascguy (Christopher Nielsen)]

Replying to jmroot:

:info:build compress/zstd_ldm_geartab.h:15: warning: integer constant is too large for 'long' type

Those warnings are also likely to be unsafe to ignore. Building with -std=c99 might help.

Agreed, those caused some serious tingling of my Spidey Sense, too. I'll take a look, as part of the overall effort.