Opened 8 months ago
Closed 8 months ago
#69280 closed defect (fixed)
skey @1.1.5: implicit declaration of functions
Reported by: | grumpybozo (Bill Cole) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | 2.9.1 |
Keywords: | haspatch catalina bigsur monterey sonoma ventura | Cc: | |
Port: | skey |
Description
It is an extremely old port out of OpenBSD which appears to be unmaintained. But it works.
Patch is just the addition of #include statements which give various files explicit declarations of various things like islower, warnx, err, etc.
Attachments (1)
Change History (4)
Changed 8 months ago by grumpybozo (Bill Cole)
Attachment: | patch-impl-decl.diff added |
---|
comment:1 Changed 8 months ago by ryandesign (Ryan Carsten Schmidt)
Keywords: | catalina bigsur added |
---|---|
Owner: | set to ryandesign |
Status: | new → accepted |
Summary: | skey @1.1.5 fails to build on macOS >11 with multiple implicit declaration issues. PATCH INCLUDED → skey @1.1.5: implicit declaration of functions |
Thanks for the patch. In addition to this, similar fixes are needed in the configure script:
---> Configuring skey Warning: Configuration logfiles contain indications of -Wimplicit-function-declaration; check that features were not accidentally disabled: exit: found in skey-1.1.5/config.log memcmp: found in skey-1.1.5/config.log
I'll take a look.
Implicit declaration of functions became an error in Xcode 12. Xcode 12 is compatible with Catalina, so the problem potentially affects Catalina and later (even though our Catalina buildbot worker uses Xcode 11 so it is not affected).
comment:2 Changed 8 months ago by ryandesign (Ryan Carsten Schmidt)
After fixing this, there are still a bazillion warnings of the type
warning: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Wdeprecated-non-prototype]
which I'm not tackling today.
comment:3 Changed 8 months ago by ryandesign (Ryan Carsten Schmidt)
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
Note: See
TracTickets for help on using
tickets.
Patch to add includes of ctype.h and err.h to correct implicit declaration errors in multiple files.