Opened 6 months ago

Closed 6 months ago

#69692 closed defect (fixed)

ImageMagick7 @7.1.1-29_1 [-x11]: Installation/build fails

Reported by: frkd-dev (Oleksandr) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: Dave-Allured (Dave Allured)
Port: ImageMagick7

Description (last modified by ryandesign (Ryan Carsten Schmidt))

The installation of ImageMagick7 fails with the following errors:

:info:build Magick++/lib/Color.cpp:246:17: error: use of undeclared identifier 'PixelPacket'
:info:build       _pixel = (PixelPacket *)NULL;
:info:build                 ^
:info:build Magick++/lib/Color.cpp:246:30: error: expected expression
:info:build       _pixel = (PixelPacket *)NULL;
:info:build                              ^
:info:build 2 errors generated.

This error is introduced by the port's patch for "Color.cpp" file [1].

The upstream is using now the PixelInfo type instead of PixelPacket, and I believe that causes the error.

The patch itself can be retired very soon since the upstream a couple of days ago ditched nullptr in favor of (PixelInfo*)NULL type casting [2]. This change wasn't released yet but we should expect this soon.

[1]: https://github.com/macports/macports-ports/blob/master/graphics/ImageMagick7/files/Color.cpp.patch

[2]: https://github.com/ImageMagick/ImageMagick/blob/main/Magick%2B%2B/lib/Color.cpp#L246

Change History (4)

comment:1 Changed 6 months ago by frkd-dev (Oleksandr)

Description: modified (diff)

comment:2 Changed 6 months ago by frkd-dev (Oleksandr)

comment:3 Changed 6 months ago by ryandesign (Ryan Carsten Schmidt)

Cc: Dave-Allured added
Description: modified (diff)
Keywords: haspatch added
Owner: set to ryandesign
Status: newaccepted

Oh, shoot, sorry, I didn't notice that difference between 6 and 7 when I added the patch.

comment:4 Changed 6 months ago by frkd-dev (Oleksandr)

Resolution: fixed
Status: acceptedclosed

In e4eea5179d3daee5a26c7bad0321b34451852a26/macports-ports (master):

ImageMagick7: fix port installation & build

Fixes the installation of the port by aligning a type in the port's
patch with the upstream.

Fixes: #69692

Note: See TracTickets for help on using tickets.