Changes between Version 1 and Version 3 of Ticket #69692


Ignore:
Timestamp:
Apr 7, 2024, 10:47:30 PM (6 months ago)
Author:
ryandesign (Ryan Carsten Schmidt)
Comment:

Oh, shoot, sorry, I didn't notice that difference between 6 and 7 when I added the patch.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #69692

    • Property Owner set to ryandesign
    • Property Keywords haspatch added
    • Property Status changed from new to accepted
    • Property Cc Dave-Allured added

  • Ticket #69692 – Description

    v1 v3  
    1212}}}
    1313
    14 This error is introduced by the port's patch for "Color.cpp" file [1].
     14This error is introduced by the port's patch for "Color.cpp" file ![1].
    1515
    16 The upstream is using now the "PixelInfo" type instead of "PixelPacket", and I believe that causes the error.
     16The upstream is using now the `PixelInfo` type instead of `PixelPacket`, and I believe that causes the error.
    1717
    18 The patch itself can be retired very soon since the upstream a couple of days ago ditched "nullptr" in favor of "(PixelInfo*)NULL" type casting [2]. This change wasn't released yet but we should expect this soon.
     18The patch itself can be retired very soon since the upstream a couple of days ago ditched `nullptr` in favor of `(PixelInfo*)NULL` type casting ![2]. This change wasn't released yet but we should expect this soon.
    1919
    2020
    21 [1]: https://github.com/macports/macports-ports/blob/master/graphics/ImageMagick7/files/Color.cpp.patch
     21![1]: https://github.com/macports/macports-ports/blob/master/graphics/ImageMagick7/files/Color.cpp.patch
    2222
    23 [2]: https://github.com/ImageMagick/ImageMagick/blob/main/Magick%2B%2B/lib/Color.cpp#L246
     23![2]: https://github.com/ImageMagick/ImageMagick/blob/main/Magick%2B%2B/lib/Color.cpp#L246