libnfs @5.0.3: error: ‘IFNAMSIZ’ undeclared here (not in a function)

[barracuda156]

In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_libnfs/libnfs/work/libnfs-5.0.3/nsm/nsm.c:27:
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_libnfs/libnfs/work/libnfs-5.0.3/include/libnfs-private.h:178: error: ‘IFNAMSIZ’ undeclared here (not in a function)
In file included from /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_libnfs/libnfs/work/libnfs-5.0.3/nlm/nlm.c:27:
/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_devel_libnfs/libnfs/work/libnfs-5.0.3/include/libnfs-private.h:178: error: ‘IFNAMSIZ’ undeclared here (not in a function)
make[2]: *** [nsm/CMakeFiles/nfs_nsm.dir/nsm.c.o] Error 1

Also fails with gcc13, with more errors.

Upstream issue: ​https://github.com/sahlberg/libnfs/issues/455

[ryandesign (Ryan Carsten Schmidt)]

It failed with the same error on the 10.8 and earlier buildbot workers but succeeded on the 10.9 and later workers.

Comparing the buildbot logs, the only difference between the 10.8 and 10.9 configure phases is that 10.8 couldn't find net/if.h:

-- Looking for net/if.h
-- Looking for net/if.h - not found

while 10.9 could:

-- Looking for net/if.h
-- Looking for net/if.h - found

net/if.h exists on 10.8 and is where IFNAMSIZ is defined.

Can you attach your config.log so that we can investigate why it couldn't find net/if.h? I suspect a necessary header has not been included. I recall this being a common problem on 10.8 and earlier.

[ryandesign (Ryan Carsten Schmidt)]

Comparing the 10.8 and 10.9 versions of /usr/include/net/if.h, the 10.9 version adds the line #include <sys/socket.h> so that may be the missing include in the libnfs configure test.

[barracuda156]

Replying to ryandesign:

Comparing the 10.8 and 10.9 versions of /usr/include/net/if.h, the 10.9 version adds the line #include <sys/socket.h> so that may be the missing include in the libnfs configure test.

Yes, thank you, that is the thing, I guess. Will try it.

[barracuda156]

In 06d3e5ebddf256c97428d3616da2f1130ac878de/macports-ports (master):

libnfs: fix for < 10.9

Fixes: #69724