R-fs @1.6.3: error: incompatible function pointer types

[ryandesign (Ryan Carsten Schmidt)]

​https://build.macports.org/builders/ports-10.7_x86_64-builder/builds/185664/steps/install-port/logs/stdio

src/unix/fs.c:552:57: error: incompatible function pointer types passing 'int (uv__dirent_t **, uv__dirent_t **)' (aka 'int (struct dirent **, struct dirent **)') to parameter of type 'int (*)(const void *, const void *)' [-Wincompatible-function-pointer-types]
  n = scandir(req->path, &dents, uv__fs_scandir_filter, uv__fs_scandir_sort);
                                                        ^~~~~~~~~~~~~~~~~~~
/usr/include/dirent.h:129:37: note: passing argument to parameter here
    int (*)(struct dirent *), int (*)(const void *, const void *)) __DARWIN_INODE64(scandir);
                                    ^
1 error generated.

[barracuda156]

I will update locally fundamental packages and try to sort out reported failures.

[barracuda156]

Replying to ryandesign:

Ah, it uses clang-16 on 10.7 now. I think we saw the same error with some Ruby ports? Then the fix should be to make it a warning. Nothing suddenly broke down in R-fs itself.

[barracuda156]

Same issue here, since it also uses a bundled libuv: ​https://ports.macports.org/port/R-httpuv/details Only on 10.7.

[ryandesign (Ryan Carsten Schmidt)]

It's not that something suddenly broke. It's that something has always been wrong in the code, and the compiler was warning about it, and now the developers of the compiler consider the problem to be so serious that it has been elevated from a warning to an error. I don't, therefore, think the best course of action is to downgrade the error back to a warning again. Instead, the problem should be fixed properly (by the developers) so that the error or warning does not occur.

[barracuda156]

In 21a0ce995e9777f5cfd4e83e37ea2172331b41df/macports-ports (master):

R-fs, R-httpuv: fix build on 10.7 with clang-16

Closes: #69853