chez-scheme @10.0.0: error: use of unknown builtin '__builtin_add_overflow'

[barracuda156]

There are no logs anymore, but I open the issue since I need this port for idris2. It builds and works on my 10.6 ppc, so should be fixable on x86 for sure.

[ryandesign (Ryan Carsten Schmidt)]

I reran the buildbot builds and the error is:

c/pb.c:122:10: error: use of unknown builtin '__builtin_add_overflow' [-Wimplicit-function-declaration]
    case COMMON_INSTR(pb_bin_op_pb_signal_pb_add_pb_register)
         ^
c/pb.c:51:28: note: expanded from macro 'COMMON_INSTR'
#define COMMON_INSTR(x) x: doi_ ## x(instr); break;
                           ^
<scratch space>:73:1: note: expanded from here
doi_pb_bin_op_pb_signal_pb_add_pb_register
^
c/pb.h:384:4: note: expanded from macro 'doi_pb_bin_op_pb_signal_pb_add_pb_register'
   do_pb_bin_op_pb_signal_pb_add_pb_register(INSTR_drr_dest(instr), INSTR_drr_reg1(instr), INSTR_drr_reg2(instr))
   ^
c/pb.h:390:12: note: expanded from macro 'do_pb_bin_op_pb_signal_pb_add_pb_register'
    flag = __builtin_add_overflow(a, b, &r);                         \
           ^

[ryandesign (Ryan Carsten Schmidt)]

In #60698 we worked around the problem by blacklisting {clang < 800}. It would be better if chez-scheme would only use __builtin_add_overflow if the compiler supports it. At present, they use it if USE_OVERFLOW_INTRINSICS is defined, and they define it for gcc 5 or greater or any version of clang, which is clearly wrong. I filed a bug report with them here: ​https://github.com/cisco/ChezScheme/issues/845

[ryandesign (Ryan Carsten Schmidt)]

The error on Snow Leopard is different; see #70280.

[barracuda156]

Replying to ryandesign:

In #60698 we worked around the problem by blacklisting {clang < 800}. It would be better if chez-scheme would only use __builtin_add_overflow if the compiler supports it. At present, they use it if USE_OVERFLOW_INTRINSICS is defined, and they define it for gcc 5 or greater or any version of clang, which is clearly wrong. I filed a bug report with them here: ​https://github.com/cisco/ChezScheme/issues/845

Thank you, Ryan!

[ryandesign (Ryan Carsten Schmidt)]

​https://github.com/macports/macports-ports/pull/24700

[ryandesign (Ryan Carsten Schmidt)]

In f575f8a3495ba5afbe640a4a3dbb14f3afc44e28/macports-ports (master):

chez-scheme: Only use intrinsics if available

Closes: #70278