bind9 @9.20.0 needs C11 atomics fix

[snowflake (Dave Evans)]

The system compiler on this old version of macOS is not up to the job any more.

Here's the first error:

netmgr/netmgr.c:2396:10: error: address argument to atomic operation must be a pointer to non-const _Atomic type ('const isc_refcount_t *' (aka 'const _Atomic(uint_fast32_t) *') invalid)
        REQUIRE(VALID_NMHANDLE(handle));
        ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
netmgr/netmgr-int.h:243:3: note: expanded from macro 'VALID_NMHANDLE'
         atomic_load(&(t)->references) > 0)

I build it successfully with configure.compiler=macports-clang-16

sudo port clean bind9
sudo port -s upgrade bind9 configure.compiler=macports-clang-16

[snowflake (Dave Evans)]

It builds OK with macports-clang-17 as well.

[danielluke (Daniel J. Luke)]

I’m likely going to need to have someone with access to one of these older machines help with this (perhaps we can blacklist older compilers or update the previous atomics patch….)

[jmroot (Joshua Root)]

[b1c8ede33b3dc45a87bda814baeb884d229e27a0/macports-ports]