Opened 3 weeks ago
Last modified 3 weeks ago
#70824 new defect
legacy-support provide TARGET_OS_IPHONE
Reported by: | rmottola (Riccardo) | Owned by: | |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | ports | Version: | |
Keywords: | Cc: | ||
Port: | legacy-support |
Description
I noticed that several ports start "breaking" because of TARGET_OS_IPHONE not being defined. E.g. https://github.com/LuaJIT/LuaJIT/pull/1189/files
The fix is incredibly trivial, but upstream often forgets about that. We can fight and make a patch for each and maintain it or hope it is upstreamed. However, often legacy-support is already used. I wonder if there is a good place and way to define it? Of course to 0, NO, or what is needed. We don't need those code sections at all on Mac
Note: See
TracTickets for help on using
tickets.
add here
https://github.com/macports/macports-legacy-support/blob/master/include/TargetConditionals.h